Skip to content

fix: cleanup of serializing optional fields in request/response types.#19

Merged
peterhuene merged 3 commits intostjude-rust-labs:mainfrom
peterhuene:fix-serialization
Jun 10, 2025
Merged

fix: cleanup of serializing optional fields in request/response types.#19
peterhuene merged 3 commits intostjude-rust-labs:mainfrom
peterhuene:fix-serialization

Conversation

@peterhuene
Copy link
Contributor

@peterhuene peterhuene commented Jun 5, 2025

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

@peterhuene peterhuene requested a review from claymcleod June 5, 2025 19:46
@peterhuene peterhuene self-assigned this Jun 5, 2025
Copy link
Member

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good. These are mostly nits.

@peterhuene peterhuene requested a review from claymcleod June 6, 2025 18:30
@peterhuene peterhuene merged commit 56cb8d7 into stjude-rust-labs:main Jun 10, 2025
6 checks passed
@peterhuene peterhuene deleted the fix-serialization branch June 10, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants